Skip to content

README update: song highlighting implemented#384

Closed
oleggtro wants to merge 1 commit intojpochyla:masterfrom
oleggtro:docs-song-highlighting-implemented
Closed

README update: song highlighting implemented#384
oleggtro wants to merge 1 commit intojpochyla:masterfrom
oleggtro:docs-song-highlighting-implemented

Conversation

@oleggtro
Copy link
Copy Markdown
Contributor

I don't really know, what you meant by this, but tried it out on my local machine and it seems to be working fine.
Did someone just forget to update the readme?

@Insprill
Copy link
Copy Markdown
Collaborator

@jpochyla Can you confirm what you mean here?

@jpochyla
Copy link
Copy Markdown
Owner

Hi, sure!

Highlight now-playing track only in the correct album / playlist

I don't really know how to approach this. Track is always playing in a context (album, top tracks, search etc), and I think that now-playing track displayed in the now-playing context should look different from track that is technically now-playing (has the same track ID), but is displayed in a different context.

Keep highlighted track in viewport

More straightforward. Auto-scroll to reveal tracks when they start to play, if the mouse cursor is not active (hovering the window or maybe not moving for a while?).

@Insprill
Copy link
Copy Markdown
Collaborator

Closing since those aren't implemented yet

@Insprill Insprill closed this Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants