Add follow and unfollow playlist support#399
Conversation
Insprill
left a comment
There was a problem hiding this comment.
Thank you for the PR! In Spotify, there's a distinction between playlists you've created and those you've followed. You can't unfollow a playlist you created, only delete it. With this PR, if you unfollow a playlist you created, it'll still exist, but won't show in your library. If I'm misunderstanding something, please correct me, but I don't think this is intended behavior.
|
Yes, you are correct about the behavior related to unfollowing a playlist you've created. So far, I haven't seen an option to delete such a playlist. On spotify web api concepts page spotify says:
As a workaround we can omit "Unfollow" menu item for playlists you've created while retaining the ability to follow and unfollow other playlists. |
|
Looking at it again, I think the current behavior is fine, and I was just misunderstanding Spotify's UI. As it says in the documentation you referenced, there's no such thing as deleting a playlist. When the Spotify UI says 'Delete', it simply unfollows it, and it can still be accessed and refollowed again if you know its ID. The only other critique I have is the fact that there's no confirmation before deleting a playlist. I can easily see someone deleting a playlist they meant to copy the link to, and having no way of finding it again. This could be implemented by creating a small child window, similar to how the preferences window is handled, that just has some text and Yes/ No buttons. Implementing that will be a little complex, so if anyone has another idea feel free to share. |
|
I've added a confirmation dialog window, but since I'm not very familiar with Druid, I may have made some kludges 🚓 concerning the handling of events in inappropriate places (new window creation and their environment). Additionally, I'm uncertain about the padding and window size of the confirmation dialog window. Please, feel free to provide any corrections or suggestions, as I appreciate your input. |
|
Thank you for the review! |
Users can now follow and unfollow playlists. Updated the UI [context menu] to include buttons for following and unfollowing playlists.