Implemented playlist rename functionality#409
Merged
Insprill merged 5 commits intojpochyla:masterfrom May 5, 2023
Merged
Conversation
Insprill
requested changes
May 5, 2023
Collaborator
Insprill
left a comment
Insprill
left a comment
There was a problem hiding this comment.
Looks good, however, instead of reloading playlists from the API when they're renamed, we can just update the local name of it. That can be implemented similarly to how saved tracks and albums are updated at https://github.com/jpochyla/psst/blob/master/psst-gui/src/data/mod.rs#L293-L305. This would fix the issue of the playlist name being one-rename out of date, most likely due to Spotify's API not updating in time for the load request.
Author
|
Gotcha, seems like it should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added rename playlist support + tried to standardize styles for rename and unfollow dialog windows.