fix: clears playlist positions to zero before recalculating on changing playlist (fix #420)#422
Merged
Insprill merged 1 commit intojpochyla:masterfrom May 21, 2023
Conversation
Insprill
approved these changes
May 21, 2023
Collaborator
Insprill
left a comment
Insprill
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the fix!
Contributor
|
Oh wow, thank you @cameronraw! I was trying to fix this in #387 but as @Insprill pointed out, I still had to figure out how it was happening. Turns out, this is it haha. |
Contributor
Author
|
No problem, @arch-btw ! The change was already suggested in the original issue, it was a nice and easy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny change to fix the bug mention in issue #420 whereby an out of bounds error appears due to playlist lengths not being returned to zero upon changing to a different playlist.