Skip to content

Makes Sidebar/Main_view split resizable#448

Closed
Liberontissauri wants to merge 1 commit intojpochyla:masterfrom
Liberontissauri:master
Closed

Makes Sidebar/Main_view split resizable#448
Liberontissauri wants to merge 1 commit intojpochyla:masterfrom
Liberontissauri:master

Conversation

@Liberontissauri
Copy link
Copy Markdown

I use a tilling window manager and it throws me off how large the sidebar is because of the window occupying the whole screen. Makes the split between the sidebar and the main view draggable so it can be resized.

@Liberontissauri
Copy link
Copy Markdown
Author

Maybe adding a setting in the preferences to persist the ratio between app launches would be nice, although I'm not sure about how to implement that just yet

@jacksongoode
Copy link
Copy Markdown
Collaborator

I question whether this would eventually lead to more layout bugs to resolve. If there is a way to set some min/max threshold of the side bar's resizing I think this could be acceptable. @Insprill any thoughts?

@Liberontissauri
Copy link
Copy Markdown
Author

Weirdly so, the sidebar already does have a minimum threshold for its size:

minimum_sidebar_size

I cant reduce it further. I'm not sure if this is part of druid itself, or if there's a way to change it. It does look like it exists to prevent overflow that makes content "invisible".

@Liberontissauri
Copy link
Copy Markdown
Author

Looks like it also applies to increasing the sidebar's size:
image

@jacksongoode
Copy link
Copy Markdown
Collaborator

If you can set reasonable ratios that would keep the current min and make the max Not more than 1/3 of the width, I think that might resolve any issue with the sidebar being too wide as in your example.

@jacksongoode
Copy link
Copy Markdown
Collaborator

@Liberontissauri Any followup with the suggested constraints?

@jacksongoode
Copy link
Copy Markdown
Collaborator

I'm going to close this since its a tiny change to the PR and making the sidebar dragable would introduce lots of other issues. There may be a future where we can have a button/shortcut to collapse. If you'd like, please feel free to discuss UI ideas here #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants