fix #461: No playlist on psst-gui and failed to read json error#464
Merged
jacksongoode merged 1 commit intojpochyla:masterfrom Apr 1, 2024
Merged
Conversation
Makes playlist images an optional Vector.
Insprill
approved these changes
Mar 30, 2024
Collaborator
Insprill
left a comment
There was a problem hiding this comment.
LGTM at a glance, Thank you! I can't test this right now, so I'll wait for someone else to sign off before merging.
Collaborator
|
Though I hadn't had this error before, this build does work for me. Was there a way to reproduce it? |
Contributor
Author
|
One reproducer for me is having an empty playlist, which I might have created by mistake using Spotify's app. Here's a snippet of the playlists json from Spotify. I've redacted some fields for privacy: {
"collaborative": false,
"description": "",
"external_urls": {
"spotify": "https://open.spotify.com/playlist/MY_PLAYLIST_ID"
},
"href": "https://api.spotify.com/v1/playlists/MY_PLAYLIST_ID",
"id": "MY_PLAYLIST_ID",
"images": null,
"name": "My Playlist #66",
"owner": {
"display_name": "Nicolas",
"external_urls": {
"spotify": "https://open.spotify.com/user/MY_USER_ID"
},
"href": "https://api.spotify.com/v1/users/MY_USER_ID",
"id": "MY_USER_ID",
"type": "user",
"uri": "spotify:user:MY_USER_ID"
},
"primary_color": null,
"public": true,
"snapshot_id": "SNAPSHOT_ID",
"tracks": {
"href": "https://api.spotify.com/v1/playlists/MY_PLAYLIST_ID/tracks",
"total": 0
},
"type": "playlist",
"uri": "spotify:playlist:MY_PLAYLIST_ID"
} |
Collaborator
|
@nicolasf I can confirm that an empty playlist will trigger this in main and this PR resolves that! |
|
Nice work @nicolasf thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes playlist images an optional Vector.