Add alert message for when tracks are added to the queue#491
Merged
jacksongoode merged 1 commit intojpochyla:masterfrom Jul 4, 2024
jholdnak:master
Merged
Add alert message for when tracks are added to the queue#491jacksongoode merged 1 commit intojpochyla:masterfrom jholdnak:master
jacksongoode merged 1 commit intojpochyla:masterfrom
jholdnak:master
Conversation
jacksongoode
approved these changes
Jul 4, 2024
Collaborator
jacksongoode
left a comment
jacksongoode
left a comment
There was a problem hiding this comment.
This looks great! Thank you for contributing - and especially as it's your first time contributing to an OSS project!
Collaborator
|
@jholdnak If you want an even trickier challenge, you'll find that some of the alert messages don't disappear when added in succession. I think there's some issue with the debounce time. Each notification needs a timer that will cause it to vanish after it appears. :) I'd be glad to help you with this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to tell the user that the song of their choice was added to the queue. Feel free to leave me some feedback as this is my first time programming in Rust, and making an open-source contribution.