Fix for missing album metadata when song played from album#581
Merged
jacksongoode merged 4 commits intomainfrom Jan 30, 2025
Merged
Fix for missing album metadata when song played from album#581jacksongoode merged 4 commits intomainfrom
jacksongoode merged 4 commits intomainfrom
Conversation
jacksongoode
force-pushed
the
jackson/dl-art
branch
from
c918952 to
892193e
Compare
Collaborator
Author
|
@SO9010 If you're on Linux could you do a quick check to see if this resolved the mpris album issues? |
Collaborator
|
Yes, doing that now :) |
Collaborator
Collaborator
Author
|
@SO9010 Could you also just have a look through the PR. Just a sanity check in case :) |
Collaborator
Author
Collaborator
|
@jacksongoode I just had a thought: It would be nice for consistency to have it so that we can also click on all the large covers within the album/artist views. |
SO9010
reviewed
Jan 30, 2025
SO9010
reviewed
Jan 30, 2025
Collaborator
|
I had a look through it and added a couple of comments. I like the download feature, but it feels very hidden; it would be nicer if we could right-click on it and then download it like that. We could also say where it downloads after it has been downloaded, as that is not user-specified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably resolves a few issues. One that I noticed was that the album metadata was unknown when we looked at the lyrics of a song that was played from the album, but outside of the context of an album if the song is played from a playlist it does have that album title. I think this could also be related to the MPRIS issue though I'm not sure #425 #368.