Skip to content

Lastfm scrobbler instance is not created on startup #599#601

Merged
jacksongoode merged 1 commit intojpochyla:mainfrom
marcfusch:main
Apr 20, 2025
Merged

Lastfm scrobbler instance is not created on startup #599#601
jacksongoode merged 1 commit intojpochyla:mainfrom
marcfusch:main

Conversation

@marcfusch
Copy link
Copy Markdown
Contributor

HI, I moved the instructions to update the scrobbler instance into a function that is called on app startup and is also called if the config file changes. This now fixes #599

@arch-btw
Copy link
Copy Markdown
Contributor

Hmm, is it possible that this causes the login info to be removed? Have to login to last.fm on restart:

psst_gui::controller::playback] Last.fm scrobbling is disabled, clearing Scrobbler instance.

@marcfusch
Copy link
Copy Markdown
Contributor Author

marcfusch commented Apr 19, 2025

Hmm, is it possible that this causes the login info to be removed? Have to login to last.fm on restart:

psst_gui::controller::playback] Last.fm scrobbling is disabled, clearing Scrobbler instance.

Actually it should not clear anything if I am not mistaken. But it may be worth the watch because my biggest question is why does the clear data gets written only once. This might be related to #598 then

@jacksongoode
Copy link
Copy Markdown
Collaborator

Can you confirm that this PR resolves both issues?

@marcfusch
Copy link
Copy Markdown
Contributor Author

Can you confirm that this PR resolves both issues?

Nope this only solves the scrobbler instance during startup

@arch-btw
Copy link
Copy Markdown
Contributor

Got it, I was just able to reproduce the bug on main, so it is indeed not related to this PR.

@jacksongoode jacksongoode merged commit 5d5418d into jpochyla:main Apr 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lastfm scrobbler instance is not created on startup

3 participants