Remember last volume state when closing/reopening application#606
Merged
jacksongoode merged 1 commit intojpochyla:mainfrom May 1, 2025
Merged
Remember last volume state when closing/reopening application#606jacksongoode merged 1 commit intojpochyla:mainfrom
jacksongoode merged 1 commit intojpochyla:mainfrom
Conversation
Collaborator
|
This is good, but it might make sense to add some debounce so that we aren't writing to the config every time we scroll the slider. |
Contributor
Author
|
Forgive me if I'm misunderstanding the code, but I'm pretty sure what I added would work so that the write to config would only occur when the main window was being closed, which is when we'd save the config and close all windows anyway. I added debug statements on my end just to double check and it seems like the write only occurs on app exit |
Contributor
|
Would this save the current volume in case of a crash, too? |
Collaborator
|
No it wouldn't, but that would require saving on volume change, which could be an improvement to this if someone desired to make a PR for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.