Skip to content

Update ureq and bump all dependencies#613

Merged
SO9010 merged 6 commits intomainfrom
Update-Ureq
May 19, 2025
Merged

Update ureq and bump all dependencies#613
SO9010 merged 6 commits intomainfrom
Update-Ureq

Conversation

@SO9010
Copy link
Copy Markdown
Collaborator

@SO9010 SO9010 commented May 18, 2025

@jacksongoode could I get your test and quick look over for this? It should be all fine. I tried to keep the flow to as similar as to what it was before. Which mean that I added a struct to the bottom which helps with creating the request, much like the request builder but for this need. Without this, I found that I couldn't get it to work using the request builder as when wanting to add a query it wouldnt let us do that,

Closes #596

@SO9010 SO9010 requested a review from jacksongoode May 18, 2025 19:38
@SO9010
Copy link
Copy Markdown
Collaborator Author

SO9010 commented May 18, 2025

Wait, I need to do psst-core!

Also, I'm not sure about the lastfm scrobbling support. We get issues, like bringing in old ureq dependencies, and more desperately this which won't be supported anymore by rust. I think that we should focus on making our own API for this rather than relying on a third party dependencies. I will happily help...

@SO9010
Copy link
Copy Markdown
Collaborator Author

SO9010 commented May 18, 2025

I don't quite understand the oauth crate do you think you could bump that? It looks like a lot changed @jacksongoode

Edit: It would be good, to reduce footprint, to use the ureq flag https://docs.rs/oauth2/latest/oauth2/ so we dont need to add reqwest!

@SO9010 SO9010 self-assigned this May 18, 2025
@SO9010 SO9010 added the help wanted Extra attention is needed label May 18, 2025
@SO9010 SO9010 marked this pull request as draft May 18, 2025 20:15
@SO9010 SO9010 marked this pull request as ready for review May 18, 2025 20:56
@SO9010 SO9010 removed the help wanted Extra attention is needed label May 18, 2025
@jacksongoode
Copy link
Copy Markdown
Collaborator

Edit: It would be good, to reduce footprint, to use the ureq flag docs.rs/oauth2/latest/oauth2 so we dont need to add reqwest!

Right! So this would mean oauth2 = { version = "...", default-features = false }. I'd say if the changes there are minimal you could go ahead a try to remove the reqwest dependency there too.

I'll get a chance to look today.

@SO9010
Copy link
Copy Markdown
Collaborator Author

SO9010 commented May 18, 2025

I added the changed cargo.toml to be what is needed, so if you want to work directly on this pr i think it would make sense to do so! oauth2 sadly uses ureq 2 maybe with my new-found skill of ureq 3.0 I'll update theirs too. 🤣

Edit: They actually reexport ureq here is the related pr, I have asked if they are able to implement the flag to reexport ureq 3 instead of 2.

Edit 2: Nevermind I think they do have to change their internal code as well!

@jacksongoode
Copy link
Copy Markdown
Collaborator

Edit 2: Nevermind I think they do have to change their internal code as well!

Hmm, I see. Maybe it would be good to merge this first and then see if we can tackle the Oauth stuff.

@SO9010
Copy link
Copy Markdown
Collaborator Author

SO9010 commented May 19, 2025

Sounds good, I'll revert the last commit and then merge it!

@SO9010 SO9010 merged commit 6eae47c into main May 19, 2025
9 checks passed
@SO9010 SO9010 deleted the Update-Ureq branch May 19, 2025 10:52
@jacksongoode
Copy link
Copy Markdown
Collaborator

Post-merge all looked good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ureq to 3.0.10

2 participants