Conversation
|
Wait, I need to do psst-core! Also, I'm not sure about the lastfm scrobbling support. We get issues, like bringing in old ureq dependencies, and more desperately this which won't be supported anymore by rust. I think that we should focus on making our own API for this rather than relying on a third party dependencies. I will happily help... |
|
I don't quite understand the oauth crate do you think you could bump that? It looks like a lot changed @jacksongoode Edit: It would be good, to reduce footprint, to use the ureq flag https://docs.rs/oauth2/latest/oauth2/ so we dont need to add reqwest! |
Right! So this would mean I'll get a chance to look today. |
|
I added the changed cargo.toml to be what is needed, so if you want to work directly on this pr i think it would make sense to do so! oauth2 sadly uses ureq 2 maybe with my new-found skill of ureq 3.0 I'll update theirs too. 🤣 Edit: They actually reexport ureq here is the related pr, I have asked if they are able to implement the flag to reexport ureq 3 instead of 2. Edit 2: Nevermind I think they do have to change their internal code as well! |
Hmm, I see. Maybe it would be good to merge this first and then see if we can tackle the Oauth stuff. |
|
Sounds good, I'll revert the last commit and then merge it! |
|
Post-merge all looked good! |
@jacksongoode could I get your test and quick look over for this? It should be all fine. I tried to keep the flow to as similar as to what it was before. Which mean that I added a struct to the bottom which helps with creating the request, much like the request builder but for this need. Without this, I found that I couldn't get it to work using the request builder as when wanting to add a query it wouldnt let us do that,
Closes #596