Conversation
jacksongoode
left a comment
jacksongoode
left a comment
There was a problem hiding this comment.
Had a few questions.
| } | ||
|
|
||
| pub fn get_made_for_you(&self) -> Result<MixedView, Error> { | ||
| // 0JQ5DAUnp4wcj0bCb3wh3S -> Daily mixes |
There was a problem hiding this comment.
This comment should be changed too.
There was a problem hiding this comment.
I think I get what you mean, changed from daily mixes to made for you
There was a problem hiding this comment.
Ah well I was thinking the hash should be updated in the comment to 0JQ5DAqAJXkJGsa2DyEjKi
| .query("fields", "260") | ||
| .header("Authorization", format!("Bearer {token}")); | ||
|
|
||
| let result: Cached<User> = self.load_cached(request, "User_info", "usrinfo")?; |
There was a problem hiding this comment.
Why are we no longer using Cached?
There was a problem hiding this comment.
I was thinking it makes more sense to not cache it because if people travel around a lot it could break it?
There was a problem hiding this comment.
Hmm, I think we ought to cache it, otherwise there will be latency in hitting ip-api.com everytime we load the home section.
jacksongoode
left a comment
jacksongoode
left a comment
There was a problem hiding this comment.
Small a few small adjustments, feel free to merge.
2 participants
@jacksongoode can you have a quick look through this, it had to be updated to v2.