Add darktheme prototype: WIP#7
Closed
JojiiOfficial wants to merge 1 commit intojpochyla:miniaudiofrom
JojiiOfficial:miniaudio
Closed
Add darktheme prototype: WIP#7JojiiOfficial wants to merge 1 commit intojpochyla:miniaudiofrom JojiiOfficial:miniaudio
JojiiOfficial wants to merge 1 commit intojpochyla:miniaudiofrom
JojiiOfficial:miniaudio
Conversation
Owner
|
Thanks! Real theming support would indeed require:
|
Author
|
But on MacOS it would not be cross platform. Or what exactly are you talking about? |
Author
|
Yeah a config file sounds good... But for this, as @jpochyla already said, quite some things need to be done first. |
Owner
|
As of 408e8ab there is a simple dark theme added. More work on colors is needed, it's not very pleasant right now, but it's a start. I'll close this, please re-open with any color customizations on top of master. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I created a dark-theme implementation prototype. I couldn't come up with an idea how to implement the dark theme for the menu buttons properly, since they are constants and can't be made variables easily. So this is WIP for now. I thought about making dark-theme a feature but tbh I prefer it to be an option which should become a preference in some kind of option/config menu later on.