Closed
Conversation
Owner
|
Great! Yes we can obsess about the logo later, thank you! And it's a good reminder for me to attribute the icons properly. Let's solve the conflicts and merge this? |
Owner
|
Merged in 0a2d93b, thanks! |
Contributor
Author
|
My bad for not getting back to this sooner. Got a lot of plates in the air |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #74
Turns out druid doesn't yet have support for setting the window icon linebender/druid#1162 so this PR just creates an icon from the logo svg path already present in this app and the spotify colors. It also introduces a build script in order to set the icon for the app exe on windows. Doing similar for other platforms will require more work that I don't know how to do.
Here is the icon I added:
This is obviously just a first pass, feel free to take it or leave it. Just figured I'd get the ball rolling.