Conversation
Call super.setConfiguration, instead of just assigning cfg. Signed-off-by: Andrés Alcarraz <alcarraz@gmail.com>
Signed-off-by: Andrés Alcarraz <alcarraz@gmail.com>
alcarraz
commented
Jan 7, 2026
Comment on lines
-341
to
-346
| } catch (NullPointerException ex) { | ||
| if (isJavaVersionAtMost(JAVA_14)) { | ||
| assertNull(ex.getMessage(), "ex.getMessage()"); | ||
| } else { | ||
| assertEquals("Cannot invoke \"org.jpos.core.Configuration.get(String)\" because \"this.cfg\" is null", ex.getMessage(), "ex.getMessage()"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This message was too specific, the modification in this PE, makes the NPE to throw in the parent class with a different message, we would be testing SMAdapter instead of this class.
Perhaps we should even remove these tests.
Member
There was a problem hiding this comment.
I agree, this test should be removed or make more generic.
ar
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
super.setConfiguration, instead of just assigningcfg. SoSMAdaptorcan set the configured debug property.