Add ISO 8583:2023 dataset support and cmfv3 packager#683
Merged
Conversation
Introduce first-class dataset handling in jPOS for composite data elements using TLV and DBM formats, including raw ICC data support for DE 55. Add dataset model classes and packagers, integrate them with GenericPackager and XML packagers, add fluent with/without helpers, support deep cloning of dataset fields, and document the new API. Keep legacy cmf.xml unchanged for backward compatibility and add cmfv3.xml with dataset-aware definitions and tests.
Remove the unsafe ISODataset cast from ISOMsg dataset cloning and clone datasets through the Dataset interface. Replace ICCDataPackager class-name matching with an explicit ISODatasetPackager capability method indicating whether the standard dataset envelope is present. Document the unsupported DBM TLV continuation path with a TODO referencing ISO 8583:2023 §4.4.4.4.
Extend DatasetPackager to decode and encode DBM datasets that carry a trailing BER-TLV section when the DBM TLV continuation bit is set. Split DBM-addressable elements from trailing TLV elements during packing, parse the trailing TLV payload during unpacking, and add round-trip coverage for the hybrid DBM+TLV format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce first-class dataset handling in jPOS for composite data elements using TLV and DBM formats, including raw ICC data support for DE 55.
Add dataset model classes and packagers, integrate them with GenericPackager and XML packagers, add fluent with/without helpers, support deep cloning of dataset fields, and document the new API.
Keep legacy cmf.xml unchanged for backward compatibility and add cmfv3.xml with dataset-aware definitions and tests.