fix(packager): correct DE-072 Data Record to LLLLVAR b..9999#686
Merged
Conversation
ISO 8583 defines DE-072 as LLLLVAR ansb..9999. Both cmf.xml and cmfv3.xml were using IFB_LLLBINARY with length=999 (LLL prefix), which is too short and uses the wrong length prefix class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISO 8583 defines DE-072 (Data Record) as
LLLLVAR ansb..9999.Both
cmf.xmlandcmfv3.xmlwere usingIFB_LLLBINARYwithlength=999, which:Fix: change both packagers to
IFB_LLLLBINARYwithlength=9999.