fix(cmfv3): remove dead emitBitmap/bitmapField attrs from DE-043 and DE-049#690
Merged
fix(cmfv3): remove dead emitBitmap/bitmapField attrs from DE-043 and DE-049#690
Conversation
…DE-049 DatasetPackager fully overrides GenericPackager.pack()/unpack() and never reads emitBitmap or bitmapField. The attributes and the id=0 IFB_BITMAP sub-field were therefore dead configuration that had no effect on the wire format but created misleading documentation and confusion. Both fields correctly encode as dataset envelopes (identifier + length + DBM/TLV content) regardless. All DatasetPackagerTest tests confirm no behavioral change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cmfv3.xmldeclaredemitBitmap="true" bitmapField="0"and anid=0 IFB_BITMAPsub-field for DE-043 (Card acceptor name/location) and DE-049 (Verification data).These attributes are dead configuration:
DatasetPackagercompletely overridesGenericPackager.pack()/unpack()and never callsisEmitBitmap()or readsbitmapField. The IFB_BITMAP sub-field at id=0 was also never consulted.Both fields already correctly encode as standard dataset envelopes:
Fix
Remove the dead attributes and the unused bitmap sub-field from both field definitions.
Tests
All
DatasetPackagerTesttests pass — no behavioral change.