Skip to content

Conversation

@rejown
Copy link
Contributor

@rejown rejown commented Mar 3, 2015

  • Get the version from jpush/__init__.py
  • Remove dependencies block from README.rst

@iwinux
Copy link

iwinux commented Jun 18, 2015

有人管吗

@iven
Copy link

iven commented Sep 7, 2015

@hupantingxue 你搞清楚问题是啥没啊……

@iwinux
Copy link

iwinux commented Sep 7, 2015

Well, I don't think there would be any non-Chinese users for this library, so let's talk in Chinese.

我们没说 requests 不需要安装,你们写了一个没法正常工作的 setup.py,在包安装的时候 import 了一个根本不需要 import 的依赖,请搞清楚状况,顺便仔细读一下 setuptools 的文档……

@tonyseek
Copy link

tonyseek commented Sep 7, 2015

……………………

setup.py 里引入版本号可以:

但不是在构建阶段就要求人家“先安装 requests 再安装 jpush”,setuptools 不是这样用的。

@GuoJing
Copy link

GuoJing commented Sep 7, 2015

JIZ! You gays zishi need to tigao. We need this fix very much!

(let's talk in Chinese.

剂子! 你们的姿势需要提高啊。

@kebot
Copy link

kebot commented Sep 7, 2015

excited!
(let's talk in Chinese

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这么写也是有问题的

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flask 也是这样写的,虽然增加了“只能在当前目录运行 python setup.py”的限制,但是起码 pip 能正常安装了。

如果要彻底避免各种限制,我个人还是建议用 bumpversion

@hupantingxue hupantingxue reopened this Sep 7, 2015
@hupantingxue
Copy link
Contributor

一天没上,我擦,没想到讨论这么激烈~

明天我再 看看怎么处理。

请哪位大牛帮忙翻译成英语?

hupantingxue added a commit that referenced this pull request Sep 8, 2015
@hupantingxue hupantingxue merged commit b5d0e42 into jpush:master Sep 8, 2015
@linkeyeasy
Copy link

Jiz!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants