fix: type hint config so they are available to mypy#52
Merged
jpvanhal merged 1 commit intojpvanhal:masterfrom Aug 22, 2020
sbdchd:steve/fix-type-setup
Merged
fix: type hint config so they are available to mypy#52jpvanhal merged 1 commit intojpvanhal:masterfrom sbdchd:steve/fix-type-setup
jpvanhal merged 1 commit intojpvanhal:masterfrom
sbdchd:steve/fix-type-setup
Conversation
@sanzoghenzo correctly pointed out that a `py.typed` file alone wasn't enough to get the typing working, we also need to move inflection into a package. fixes: #49 rel: https://www.python.org/dev/peps/pep-0561/#packaging-type-information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sanzoghenzo correctly pointed out that a
py.typedfile alone wasn'tenough to get the typing working, we also need to move inflection into
a package.
I tested this by running
./.venv/bin/python setup.py sdistand installing the generated.tar.gzfile into a blank project.First attempt without the setup.py changes didn't work, but moving to a package did.
example error:
fixes: #49
rel: https://www.python.org/dev/peps/pep-0561/#packaging-type-information