Skip to content

fix: Fix a race caused by premature-finalization when calling a method on transient PyObjects #226

Merged
jmao-denver merged 7 commits into
jpy-consortium:masterfrom
jmao-denver:add-reachability-fence-in-java
May 1, 2026
Merged

fix: Fix a race caused by premature-finalization when calling a method on transient PyObjects #226
jmao-denver merged 7 commits into
jpy-consortium:masterfrom
jmao-denver:add-reachability-fence-in-java

Conversation

@jmao-denver
Copy link
Copy Markdown
Contributor

No description provided.

@jmao-denver jmao-denver self-assigned this May 1, 2026
@jmao-denver jmao-denver marked this pull request as ready for review May 1, 2026 13:44
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/test/python/jpy_reachability_fence_test.py Outdated
Comment thread src/test/java/org/jpy/fixtures/ReachabilityFenceTestFixture.java Outdated
cpwright
cpwright previously approved these changes May 1, 2026
Copy link
Copy Markdown
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my comments are about limiting the scope of reachability.

Comment thread src/main/java/org/jpy/PyObject.java
Comment thread src/main/java/org/jpy/PyObject.java
Comment thread src/main/java/org/jpy/PyObject.java
Comment thread src/main/java/org/jpy/PyDictWrapper.java
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/main/java/org/jpy/PyDictWrapper.java
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/main/java/org/jpy/PyDictWrapper.java
Comment thread src/main/java/org/jpy/PyDictWrapper.java
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/main/java/org/jpy/PyDictWrapper.java
@jmao-denver jmao-denver requested a review from devinrsmith May 1, 2026 16:21
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
Comment thread src/main/java/org/jpy/PyDictWrapper.java Outdated
@jmao-denver jmao-denver requested a review from devinrsmith May 1, 2026 16:42
cpwright
cpwright previously approved these changes May 1, 2026
Copy link
Copy Markdown
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmao-denver jmao-denver merged commit 9bcdd6d into jpy-consortium:master May 1, 2026
85 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants