24-bit color fix for 'ms-terminal' (vs. vtwin10)#376
Merged
Conversation
Only 'vtwin10' (command.exe/ConHost.exe) got 24-bit color check. I added 'ms-terminal' with windows 10 build check, though it's not entirely clear when 'ms-terminal' became an identity, I don't think it existed in 2016? https://devblogs.microsoft.com/commandline/24-bit-color-in-the-windows-console/
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 13 13
Lines 3785 3785
Branches 671 671
=======================================
Hits 3685 3685
Misses 82 82
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 24-bit color support for kind='ms-terminal'
Only 'vtwin10' was given the 24-bit color check, though it's not entirely clear when 'ms-terminal'
became an identity, I don't think it existed in 2016? Anyway we're long past for 24-bit colors.
https://devblogs.microsoft.com/commandline/24-bit-color-in-the-windows-console/