Skip to content

Refactor and remove tv-detect#142

Merged
jquast merged 9 commits into
masterfrom
jq/tv-detect2
May 20, 2026
Merged

Refactor and remove tv-detect#142
jquast merged 9 commits into
masterfrom
jq/tv-detect2

Conversation

@jquast
Copy link
Copy Markdown
Owner

@jquast jquast commented May 20, 2026

  • telnet loop detection
  • remove 'tv-detect' integration

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing jq/tv-detect2 (dd36fda) with master (d63635e)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 95.07042% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.26%. Comparing base (d63635e) to head (dd36fda).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
telnetlib3/fingerprinting.py 92.30% 2 Missing and 2 partials ⚠️
telnetlib3/server.py 81.81% 2 Missing ⚠️
telnetlib3/server_fingerprinting.py 98.57% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   91.30%   92.26%   +0.95%     
==========================================
  Files          28       28              
  Lines        7284     7100     -184     
  Branches     1253     1236      -17     
==========================================
- Hits         6651     6551     -100     
+ Misses        426      355      -71     
+ Partials      207      194      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jquast jquast marked this pull request as ready for review May 20, 2026 15:25
@jquast jquast merged commit f58fd70 into master May 20, 2026
18 checks passed
@jquast jquast deleted the jq/tv-detect2 branch May 20, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant