-
Notifications
You must be signed in to change notification settings - Fork 61
Migrate from setup.py + setuptools to pyproject.toml + hatchling #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The new metadata isn't supported for 3.6 and 3.7: https://github.com/hugovk/wcwidth/actions/runs/19575036750/job/56057960860 Let's drop them, they've been EOL since 2021-12-23 and 2023-06-27: |
|
By thw way, since setuptools >= 61 supports PEP 621, I think we can use pyproject.toml + setuptools. |
|
|
||
| def read_sequences_from_file(filename): | ||
| fp = open(os.path.join(os.path.dirname(__file__), filename), 'r', encoding='utf-8') | ||
| fp = open(os.path.join(os.path.dirname(__file__), filename), encoding='utf-8') |
Check warning
Code scanning / CodeQL
File is not always closed Warning test
this operation
|
Any particular reason to stick with setuptools instead of something more modern? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 100 100
Branches 20 20
=========================================
Hits 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
One reason is that we can keep the setup.py in this version, which generates a warning for those who are still calling |
Fixes #151.
Replaces the deprecated license classifiers with PEP 639 metadata: https://hugovk.dev/blog/2025/improving-licence-metadata/