bugfix: IndexError when 'n' exceeds length#228
Merged
Conversation
jquast
commented
Jun 29, 2026
jquast
commented
Owner
- fix: clamp n to len(pwcs) in wcswidth/wcstwidth to avoid IndexError
- Cover wcswidth n overflow companion paths
- reduce test size
- document bugfix, prepare for 0.8.2
Passing n > len(pwcs) to wcswidth() or wcstwidth() causes an IndexError when the loop index reaches the end of the string, because `end` was set to n directly. Fix: `end = min(n, len(pwcs))` so that n larger than the string length is treated the same as measuring the whole string, which is the natural Python semantics for sized strings. Adds a regression test covering ASCII, wide characters, and ZWJ clusters.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1924 1967 +43
Branches 456 462 +6
=========================================
+ Hits 1924 1967 +43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.