This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Filterable events #6937
Merged
Filterable events #6937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
i know this was wrong already but can you just split this onto multiple lines for the object.
Contributor
There was a problem hiding this comment.
This isn't wrong. If the line fits in 100 characters, objects don't need to be split.
Contributor
There was a problem hiding this comment.
ok sorry i thought when i asked about this the other day you said if its in a function invocation it had to be ok well this is good to go then @jzaefferer 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two fixes for filterable. The first removes the invalid second string argument from the existing
_triggercall. The second adds afilterevent, as discussed in #6580. I've named itfilterinstead ofpostfilterto be consistent with other events.I haven't added any unit tests, since there was nothing to extend. The only filterable unit tests is a trivial assert.