Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Filterable events #6937

Merged
merged 2 commits into from
Jan 14, 2014
Merged

Filterable events #6937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
819a0cd
Filterable: Remove invalid _trigger argument
jzaefferer Jan 14, 2014
a379025
Filterable: Add a filter event
jzaefferer Jan 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion js/widgets/filterable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ $.widget( "mobile.filterable", {
}

this._timer = this._delay( function() {
this._trigger( "beforefilter", "beforefilter", { input: search } );
this._trigger( "beforefilter", null, { input: search } );
Copy link
Contributor

@arschmitz arschmitz Jan 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this was wrong already but can you just split this onto multiple lines for the object.

Copy link
Contributor

@scottgonzalez scottgonzalez Jan 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't wrong. If the line fits in 100 characters, objects don't need to be split.

Copy link
Contributor

@arschmitz arschmitz Jan 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sorry i thought when i asked about this the other day you said if its in a function invocation it had to be ok well this is good to go then @jzaefferer 👍


// Change val as lastval for next execution
search[ 0 ].setAttribute( "data-" + $.mobile.ns + "lastval", val );
Expand Down Expand Up @@ -117,6 +117,10 @@ $.widget( "mobile.filterable", {
}

this._refreshChildWidget();

this._trigger( "filter", null, {
items: filterItems
});
},

// The Default implementation of _refreshChildWidget attempts to call
Expand Down