Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jan 31, 2018

The same was previously done for jQuery Core.

@mgol mgol closed this Jan 31, 2018
@mgol mgol reopened this Jan 31, 2018
@mgol mgol requested review from dmethvin and timmywil January 31, 2018 16:51
@timmywil
Copy link
Member

This makes sense here because jquery-release actually commits node_modules, but we're probably going to be adding back package-lock.json to jQuery core.

@mgol
Copy link
Member Author

mgol commented Jan 31, 2018

Yeah, one day but for now npm/npm#17722 is still open and that was what triggered us removing the lock file.

@mgol mgol merged commit 57a6303 into jquery:master Feb 5, 2018
@mgol mgol deleted the package-lock branch February 5, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants