Skip to content

fix(ie): set IEDriver location in GitHub Actions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2025
Merged

fix(ie): set IEDriver location in GitHub Actions #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c676445
test(submodules): remove the need for a jtr-branch on submodules
timmywil Nov 17, 2025
564c45e
chore(package): upgrade dependencies
timmywil Nov 17, 2025
69a35ff
ci(jquery): test jQuery in Edge in IE mode
timmywil Nov 17, 2025
3c44d1b
fixup! use npm cache from setup-node; move ie test to windows-latest
timmywil Nov 17, 2025
2276c3d
fixup! upgrade Node to 24.x; use npm cache in main test workflow
timmywil Nov 17, 2025
5c50f77
fixup! add exitWithError to handle exit codes properly
timmywil Nov 17, 2025
ad643b7
fix(createDriver): set default IEDriver location in GH Actions
timmywil Nov 17, 2025
ac13c5f
fixup! typo
timmywil Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions .github/workflows/jquery-migrate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: jQuery Migrate

on:
pull_request:
push:
branches:
- main
branches: [ "main" ]
pull_request:
branches: [ "main" ]

env:
NODE_VERSION: 22.x
NODE_VERSION: 24.x

jobs:
build-and-test:
Expand All @@ -23,18 +23,20 @@ jobs:
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ env.NODE_VERSION }}

- name: Cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm install
run: npm ci

- name: Install jQuery Migrate dependencies
working-directory: test/jquery-migrate
run: npm ci

- name: Install local JTR
working-directory: test/jquery-migrate
run: npm install -D ../../

- name: Run jQuery Migrate tests
working-directory: test/jquery-migrate
run: npm it
run: npm test
30 changes: 16 additions & 14 deletions .github/workflows/jquery-mousewheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: jQuery Mousewheel

on:
pull_request:
push:
branches:
- main
branches: [ "main" ]
pull_request:
branches: [ "main" ]

env:
NODE_VERSION: 22.x
NODE_VERSION: 24.x

jobs:
build-and-test:
Expand All @@ -23,18 +23,20 @@ jobs:
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ env.NODE_VERSION }}

- name: Cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm install
run: npm ci

- name: Install jQuery Mousewheel dependencies
working-directory: test/jquery-mousewheel
run: npm ci

- name: Install local JTR
working-directory: test/jquery-mousewheel
run: npm install -D ../../

- name: Run jQuery Mousewheel tests
working-directory: test/jquery-mousewheel
run: npm it
run: npm test
30 changes: 16 additions & 14 deletions .github/workflows/jquery-ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: jQuery UI

on:
pull_request:
push:
branches:
- main
branches: [ "main" ]
pull_request:
branches: [ "main" ]

env:
NODE_VERSION: 22.x
NODE_VERSION: 24.x

jobs:
build-and-test:
Expand All @@ -23,18 +23,20 @@ jobs:
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ env.NODE_VERSION }}

- name: Cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm install
run: npm ci

- name: Install jQuery UI dependencies
working-directory: test/jquery-ui
run: npm ci

- name: Install local JTR
working-directory: test/jquery-ui
run: npm install -D ../../

- name: Run jQuery UI tests
working-directory: test/jquery-ui
run: npm it
run: npm test
55 changes: 42 additions & 13 deletions .github/workflows/jquery.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: jQuery

on:
pull_request:
push:
branches:
- main
branches: [ "main" ]
pull_request:
branches: [ "main" ]

env:
NODE_VERSION: 22.x
NODE_VERSION: 24.x

jobs:
build-and-test:
Expand All @@ -23,18 +23,47 @@ jobs:
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm ci

- name: Install jQuery dependencies
working-directory: test/jquery
run: npm ci

- name: Cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
- name: Install local JTR
working-directory: test/jquery
run: npm install -D ../../

- name: Run jQuery tests
working-directory: test/jquery
run: npm run test:browser -- -v

ie:
runs-on: windows-latest
name: Test jQuery with IEDriver
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
submodules: recursive

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm install
run: npm ci

- name: Run jQuery tests
- name: Install local JTR
working-directory: test/jquery
run: npm install -D ../../

- name: Run jQuery tests in Edge in IE mode
working-directory: test/jquery
run: npm install && npm run test:browser -- -v
run: npm run test:ie -- -v
12 changes: 11 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,25 @@ on:
pull_request:
branches: [ "main" ]

env:
NODE_VERSION: 24.x

jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm install
run: npm ci

- name: Run tests
run: npm test
Loading