Skip to content

Conversation

iliakan
Copy link
Contributor

@iliakan iliakan commented Dec 18, 2010

Repairs long-standing bug about incorrect behavior of submit bubbling in all IEs.

@csnover
Copy link
Member

csnover commented Dec 23, 2010

Could you please provide a link to some documentation that describes this issue, as well as some test cases?

@dmethvin
Copy link
Member

The ticket has some more discussion about the conditions where this occurs. I tried to find some official docs on the problem but came up empty.

The form.finds should be combined into single selectors, like form.find('input:text, input:password').

This feels like a fragile fix because it is detecting so many special cases; I was trying to think of a way we could let the synthesized submit go ahead but ignore the spurious click if it came later.

@iliakan
Copy link
Contributor Author

iliakan commented Dec 24, 2010

Yes, the IE behavior here is indeed special. But I'd not call it fragile, because the behavior is consistent across all IE versions less than 9. A better fix is welcome for sure :)

@iversant
Copy link

Why was this pull request closed?

@dmethvin
Copy link
Member

@iversant, not sure. The ticket is still open but it sounds like this patch won't work with the latest version. Also this patch didn't have a test case. Are you interested in trying a new patch?

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants