NOT FOR MERGE: test semver check still flags major breaks#6
Conversation
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Continuous integration / Check (api)" job then expand "Run api" and scroll to the end of the section. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62bf187de5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| /// Returns the invalid base58 string length (require at least 4 bytes for checksum), if encountered. |
There was a problem hiding this comment.
For downstream crates that handle checksum failures programmatically, base58ck::Error::incorrect_checksum() is the only public accessor for the incorrect/expected checksum values; removing it while base58ck remains at version 0.4.0 makes existing callers fail to compile and violates the repository's stated semver policy. Please keep this method or pair the API break with an intentional release/versioning plan.
Useful? React with 👍 / 👎.
1 participant
No description provided.