Add UNIFY_REFL_TAC to unify metavariables in equality#151
Merged
Conversation
This patch adds `UNIFY_REFL_TAC`, which is a simple extension of `UNIFY_ACCEPT_TAC` for the case when the goal is an equality `t = x` and `x` is a metavariable. If the goal is `e = f x y z` and `f` is a metavariable, it instantiates `f` with `\x y z. e` (the number of arguments does not have to be 3 and can vary). This is adopted from `UNIFY_REFL_TAC` in s2n-bignum.
jrh13
approved these changes
Feb 16, 2026
Owner
jrh13
left a comment
jrh13
left a comment
There was a problem hiding this comment.
Very nice, thank you! It's nice to see the metavariable machinery getting seriously used and also improved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
UNIFY_REFL_TAC, which is a simple extension ofUNIFY_ACCEPT_TACfor the case when the goal is an equalityt = xandxis a metavariable. If the goal ise = f x y zandfis a metavariable, it instantiatesfwith\x y z. e(the number of arguments does not have to be 3 and can vary).This is adopted from
UNIFY_REFL_TACin s2n-bignum.