Cleaning up metis#152
Merged
Merged
Conversation
This will use the implementation in lib.ml, which is slightly different. In particular, it seems that the original implementation in metis.ml would not terminate for n < 0.
Already in lib.ml
Affected function: multInt
In particular, instead of defining the order type, we use the OCaml convention of using integers. I think this patch actually makes the code a bit more robust: orderOfInt (and thus toCompare by extension) would fail if the compare function returned something other than -1/0/+1, which Repr.compare doesn't seem to exclude. The applied patch was generated by Claude Code.
Source: gilith/metis/src/Portable.sig
This should make it easier to tell whether something comes from Useful or not, as the definitions are defined are quite general. Hopefully, it also makes future refactors easier that want to move things out of Useful.
Contributor
Author
|
A lazy regression suite set up by Claude Code (setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip: #general > Cleaning up metis?#general > Cleaning up metis?
The main changes are