Restore compatibility with OCaml 4.06, Camlp5 7.10#154
Merged
Conversation
Seems like these are only available starting 4.08. Patch received from John Harrison, generated by Claude.
This reverts commit aa397c0. Seems like this causes parsing issues in old versions (OCaml 4.06, Camlp5 7.10)
Owner
|
Thanks for the quick fix! As well as the versions tested in CI, this also seems to work well on 4.05.0, 5.1.0 and 5.3.0. I'll almost certainly adopt and merge this shortly. Let me just run the complete tests first, though - I should do my due diligence this time :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the modules Int, Bool, Option and Float are not available in OCaml 4.06. Additionally, there appears to be a record parsing issue in the OCaml 4.06 + Camlp5 7.10 combo.
This PR addresses these issues, with some of the changes coming from a Claude patch generated by @jrh13 .