Skip to content

Conversation

@marksweb
Copy link
Collaborator

Preparation for 1.0

@jrief
Copy link
Owner

jrief commented Apr 20, 2021

@marksweb Thanks for your pull request. One thing to note is, that my editor uses .editorconfig and there max_line length = 119 as proposed by the Django style guide.

Until a few minutes ago, there was a typo in that file though 🤔.

@marksweb
Copy link
Collaborator Author

Thanks for the info @jrief

I've always used 80. I'll have to check if there's a pycharm plugin to read those config files. I'll revert to longer lines & then it might be ready.

@jrief
Copy link
Owner

jrief commented Apr 20, 2021

Yes, it's bundled as plugin into PyCharm and I use that all the time.
That's quite important where I work, because it also works in other IDEs such as Visual Studio Code used by my colleges.

@marksweb
Copy link
Collaborator Author

@jrief yes I've switched to project specific settings and it's picked it up nicely. Should be able to complete this release prep tonight.

@marksweb marksweb marked this pull request as ready for review April 21, 2021 01:37
@marksweb marksweb requested a review from jrief April 21, 2021 01:37
@jrief jrief merged commit d7608bd into jrief:master Apr 21, 2021
@jrief
Copy link
Owner

jrief commented Apr 21, 2021

As far as I have seen, this pull request just replaces formatting such as '{x}'.format(x=9) against f'{x}'. This means that Python-3.6 now is a minimum requirement.

@marksweb
Copy link
Collaborator Author

That's right @jrief

I looked over it & <3.5 appeared to have been removed so that became part of my checks for dropping old compatibility allowances 👍

@marksweb marksweb linked an issue Apr 21, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add Django 3.2 support

2 participants