Try to find class resource to avoid exception #8045
Merged
+30
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
reduce_invoker_exceptions
branch
from
afba384 to
f8c3015
Compare
The exception thrown here when we cannot find a class can be very expensive at boot time. For most third-party extensions, this exception will be raised twice for every bound method, due to double-checking the classloader under lock a second time. By first looking for a .class resource, we can avoid the expensive exception if it is unlikely to succeed.
This helps avoid exceptions when probing for possibly-defined invokers. Just using findResource will not pick up generated classes, so this instead provides a hasClass that will either use findResource or a set of all class names that have been defined at runtime in this classloader.
headius
force-pushed
the
reduce_invoker_exceptions
branch
from
f8c3015 to
793a9a5
Compare
|
This is complete. It does not appear to affect a single command-line launch of JRuby significantly, but for repeat launches in the same VM the results improve: for This number will increase with the number of gem-based extension methods bound. In this case it is primarily from booting stringio and strscan, I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception thrown here when we cannot find a class can be very expensive at boot time. For most third-party extensions, this exception will be raised twice for every bound method, due to double-checking the classloader under lock a second time. By first looking for a .class resource, we can avoid the expensive exception if it is unlikely to succeed.