[fix] regression calling static hash() method on Java proxy #9016
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
force-pushed
the
ji-hash-proxy-static
branch
from
613f386 to
eb1c0b2
Compare
headius
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first commit is a reproducer for the regression,
second is an attempt to fix but there are potential other approaches as well
(e.g. use an
IdentityWeakHashMapas a backing collection for theRubyClassSetto make sure we do not rely onRubyModule#hashCodecalls which now might be dynamic),the proposed fix here restores the previous
RubyModule#hashCodebehavior for Java proxies.