Skip to content

fix: remove use of deprecated JRuby method #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chadlwilson merged 2 commits into from
Apr 21, 2026
Merged

fix: remove use of deprecated JRuby method #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f1e2bf
fix: remove use of deprecated JRuby method
chadlwilson Apr 21, 2026
9e2686b
build: fix CI to use specific JRuby 10 version
chadlwilson Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ jobs:
strategy:
matrix:
java-version: [8, 21, 25]
ruby-version: [jruby-9.4, jruby-10]
ruby-version: [jruby-9.4, jruby-10.0]
task: ['', integration]
exclude:
# JRuby 10 requires Java 21 minimum
- ruby-version: jruby-10
- ruby-version: jruby-10.0
java-version: 8

fail-fast: false
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- #591: chore: clean up obsolete & deprecated code from 2.0.x and old Bundler versions
- #592: chore: relax rubyzip requirement to allow rubyzip 2.x
- #593: chore: relax jruby-rack requirement to allow compatibility with upcoming 1.3.x
- #624: chore: remove use of deprecated JRuby methods removed in JRuby 10.1

## 2.1.0

Expand Down
2 changes: 1 addition & 1 deletion ext/WarMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ protected int launchJRuby(final URL[] jars) throws Exception {

invokeMethod(rubyInstanceConfig, "processArguments", (Object) arguments);

Object runtime = invokeMethod(scriptingContainer, "getRuntime");
Object runtime = invokeMethod(provider, "getRuntime");

debug("loading resource: " + executablePath);
Object executableInput =
Expand Down