update base._query_string_builder to take params as argument #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overwriting namespace and region if given from caller as params. update requirements-dev pinned versions, remove region from batch_parametrized.json tests failed due to region not existing. Removed some problematic tests that need to be tested in a better manner.
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
===========================================
+ Coverage 78.80% 90.61% +11.80%
===========================================
Files 26 26
Lines 1203 1065 -138
===========================================
+ Hits 948 965 +17
+ Misses 255 100 -155
Continue to review full report at Codecov.
|
added 6 commits
August 29, 2021 11:08
… from official testing matrix (technically still supported)
…ing every 5 seconds for a running status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update base._query_string_builder to take params as argument to avoid overwriting namespace and region if given from caller as params. This should enable add support for namespace argument in get_job #119.
Update requirements-dev pinned versions, remove region from batch_parametrized.json tests failed due to region not existing. Removed some problematic tests that need to be tested in a better manner.