-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
pools.js.org #10393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pools.js.org #10393
Conversation
phederal
commented
Dec 10, 2025
- There is reasonable content on the page (see: No Content)
- I have read and accepted the Terms and Conditions
- The site content can be seen at pools
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
❌ This PR appears to be adding or modifying files other than the cnames_active.js file, which you shouldn't be doing.
To request a subdomain from js.org, your pull request should add a single new line to cnames_active.js that represents the subdomain you wish to request, and the target for the CNAME DNS record. There should be no other files in your PR diff.
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Commit valid, site appears to have content *
* based off https://phederal.github.io/pools/
|
FYI, before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝 |
Completed |
|
accepted? |
|
Welcome https://pools.js.org |