Skip to content

Conversation

@phederal
Copy link
Contributor

The site content is library docs

@MattIPv4 MattIPv4 changed the title Create pools.json pools.js.org Dec 10, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

❌ This PR appears to be adding or modifying files other than the cnames_active.js file, which you shouldn't be doing.

To request a subdomain from js.org, your pull request should add a single new line to cnames_active.js that represents the subdomain you wish to request, and the target for the CNAME DNS record. There should be no other files in your PR diff.

@phederal phederal closed this Dec 10, 2025
@phederal phederal reopened this Dec 10, 2025
@phederal phederal requested a review from MattIPv4 December 10, 2025 19:39
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site appears to have content *

* based off https://phederal.github.io/pools/

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed invalid labels Dec 10, 2025
@MattIPv4
Copy link
Member

FYI, before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@phederal
Copy link
Contributor Author

FYI, before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

Completed

@phederal
Copy link
Contributor Author

phederal commented Dec 11, 2025

@MattIPv4

accepted?

@indus
Copy link
Member

indus commented Dec 11, 2025

Welcome https://pools.js.org
(FYI: Looks like the basepath is incorrect now)

@indus indus merged commit aed32b4 into js-org:master Dec 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants