Skip to content

star.js.org #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2018
Merged

star.js.org #2578

merged 2 commits into from
Dec 5, 2018

Conversation

@swyxio
Copy link
Contributor

@swyxio swyxio commented Dec 5, 2018

MattIPv4
MattIPv4 requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site*. This file should contain a single line with the full js.org domain you are requesting, in this instance star.js.org.

* https://github.com/STARframework/STAR/tree/master/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Dec 5, 2018
@MattIPv4 MattIPv4 changed the title add Star.js.org star.js.org Dec 5, 2018
@swyxio
Copy link
Contributor Author

swyxio commented Dec 5, 2018

ah, sorry, i thought it was at the root of the repo. done!

MattIPv4
MattIPv4 approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit valid, CNAME present, site appears to have content*

* based off https://github.com/STARframework/STAR/tree/master/docs

@MattIPv4 MattIPv4 removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Dec 5, 2018
@indus
Copy link
Member

indus commented Dec 5, 2018

Welcome https://star.js.org

@indus indus merged commit 9f8ce32 into js-org:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees

No one assigned

Labels

add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swyxio @indus @MattIPv4