Skip to content

bathtiles.js.org #9353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

bathtiles.js.org #9353

merged 1 commit into from
Oct 31, 2024

Conversation

@Laurenyoo
Copy link
Contributor

@Laurenyoo Laurenyoo commented Oct 30, 2024

MattIPv4
MattIPv4 requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 30, 2024
@Laurenyoo
Copy link
Contributor Author

Laurenyoo commented Oct 31, 2024

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

Updated!

@Laurenyoo Laurenyoo requested a review from MattIPv4 October 31, 2024 02:14
MattIPv4
MattIPv4 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/Laurenyoo/website-bathtiles.js

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Oct 31, 2024
@indus indus changed the title bathtiles.js bathtiles.js.org Oct 31, 2024
@indus
Copy link
Member

indus commented Oct 31, 2024

Welcome https://bathtiles.js.org

@indus indus merged commit 4be3d0a into js-org:master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees

No one assigned

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Laurenyoo @indus @MattIPv4