Fix period and overtime status on follow-on log load#2
Merged
jsTron merged 1 commit intoMar 1, 2022
Merged
Conversation
Owner
jsTron
commented
Mar 1, 2022
jsTron
commented
- Rename private/static variables to underscore-camel naming convention.
- Merge log file loading calls to a single method called from each button click method.
- Extract form reset code to helper method ResetFormData.
- Extract team and period text setter method.
- Extract OverTime Win check method.
- Extract SetLoadedFileDisplays method.
- Extract PopulateDataGrid method.
- Refactor overtime check to hide OvertimeWin status when changing log files.
* Rename private/static variables to underscore-camel naming convention. * Merge log file loading calls to a single method called from each button click method. * Extract form reset code to helper method ResetFormData. * Extract team and period text setter method. * Extract OverTime Win check method. * Extract SetLoadedFileDisplays method. * Extract PopulateDataGrid method. * Refactor overtime check to hide OvertimeWin status when changing log files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.