Feature check duplicate selections#3
Merged
Conversation
* Prevent stats population to League Republic when a player name has been utilized more than once. * Distill methods. * Reduce code duplication.
* Refactor code to set and reset color background for player selection duplicates. * Distill stat send button lockout code.
* Fix web page displaying incorrectly (black frame around page) when viewed from high DPI monitor, such as 4k displays, by adding HighDPI support to Chromium.
…om/jsTron/ReboundLogParser into feature-check-duplicate-selections
jsTron
commented
Mar 3, 2022
| var changedComboBox = (sender as ComboBox); | ||
| var isHomeTeamBox = _homePlayerBoxes.Any(box => box.Name.Equals(changedComboBox.Name)); | ||
| var teamBoxes = (isHomeTeamBox ? _homePlayerBoxes : _awayPlayerBoxes); | ||
| var otherBoxes = teamBoxes.Where(box => box != changedComboBox); |
Owner
Author
There was a problem hiding this comment.
otherBoxes not used. can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.