Fix position: absolute to reference nearest positioned ancestor#276
Merged
Fix position: absolute to reference nearest positioned ancestor#276
Conversation
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
…vior Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix position: absolute to reference nearest positioned ancestor, not entire page
Fix position: absolute to reference nearest positioned ancestor
Sep 1, 2025
yorkie
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical CSS positioning bug where
position: absoluteelements were incorrectly positioned relative to the entire page instead of their nearest positioned ancestor, breaking standard web layout behavior.Problem
Previously, the layout engine treated all absolutely positioned elements as if they were positioned relative to the viewport/page, ignoring intermediate positioned ancestors. This broke expected layout for:
Solution
Implemented the missing positioning logic in the layout engine according to W3C CSS specifications:
The implementation now correctly:
position: relative,absolute,fixed, orstickyestablish containing blocks for absolutely positioned descendantsExample
Consider this HTML structure:
Before this fix: The absolutely positioned element would position relative to the entire page.
After this fix: The absolutely positioned element correctly positions relative to the nearest
position: relativeancestor.Testing
layout_position_tests.cppposition-absolute-test.htmldemonstrating correct behaviorThis change brings JSAR Runtime's CSS positioning behavior in line with standard web browsers and W3C specifications.
Fixes #275.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
registry.npmmirror.comnpm ci(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.