Add comprehensive text-align test cases to fixtures/html#313
Merged
Conversation
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] 在 fixtures/html 下,添加 text-align 的测试用例(请先看下 fixtures/html 是否有合适的已经存在文件适合存放该用例,如果没有的话,再新建一个 .html)
Add comprehensive text-align test cases to fixtures/html
Sep 16, 2025
Copilot stopped work on behalf of
yorkie due to an error
September 16, 2025 11:23
yorkie
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced the existing
text-rendering-test.htmlfile to include all text-align values supported by JSAR Runtime's CSS implementation.Background
The existing text alignment tests only covered the basic CSS text-align values (
left,center,right,justify), but JSAR Runtime's CSS parser insrc/client/cssom/values/specified/text.hppsupports additional values that were missing from the test suite.Changes
Added three missing text-align test cases:
text-align: start- Aligns text to the start edge (writing direction dependent)text-align: end- Aligns text to the end edge (writing direction dependent)text-align: match-parent- Inherits parent's text alignment behaviorEach test case includes:
Implementation Details
The changes maintain the existing file structure and follow established patterns:
Visual Result
The screenshot shows all seven text-align values now working correctly in the test suite, providing comprehensive coverage for text alignment functionality in JSAR Runtime.
Testing
Verified that all test cases render correctly and demonstrate the expected text alignment behaviors. The enhanced test file maintains backward compatibility while expanding test coverage for the complete set of supported text-align values.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
registry.npmmirror.comnpm ci(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.