Add WebGPU backend to support the record/submit draw calls on render textures#94
Merged
Add WebGPU backend to support the record/submit draw calls on render textures#94
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds WebGPU backend support to the graphics system by implementing infrastructure for recording and submitting draw calls on render textures. The changes focus on introducing a new RHI abstraction layer, refactoring the existing OpenGL code, and implementing WebGPU command buffer patterns.
Key changes:
- Introduces TrRenderHardwareInterface (RHI) abstraction to replace the existing RenderAPI system, providing better support for multiple graphics backends including WebGPU
- Implements GPU command buffer infrastructure with WebGPU-style command encoders, render pass encoders, and command execution patterns
- Refactors rendering pipeline to support multiple execution passes (default frame, XR frame, offscreen pass) and improved context management
Reviewed Changes
Copilot reviewed 88 out of 89 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/render_api.hpp/cpp | Core RHI abstraction layer replacing RenderAPI with factory pattern |
| src/renderer/gles/* | OpenGL ES implementation of GPU command buffer system |
| src/renderer/renderer.hpp/cpp | Updated renderer to use RHI and support multiple rendering passes |
| src/renderer/content_renderer.hpp/cpp | Enhanced content renderer with offscreen pass support |
| src/common/command_buffers/gpu/* | New WebGPU-style command buffer infrastructure |
| src/common/command_buffers/details/* | Updated command buffer requests with copy constructors |
Comments suppressed due to low confidence (1)
| if (__system_property_get("jsar.renderer.clear_stencil", disableStencilClearStr) >= 0) | ||
| { | ||
| if (strcmp(disableStencilClearStr, "no") == 0 || | ||
| strcmp(disableStencilClearStr, "disable")) |
There was a problem hiding this comment.
Missing equality comparison operator in the second strcmp call. Should be strcmp(disableStencilClearStr, "disable") == 0 to properly check if the string equals "disable".
Suggested change
| strcmp(disableStencilClearStr, "disable")) | |
| strcmp(disableStencilClearStr, "disable") == 0) |
| GL_TEXTURE_INTERNAL_FORMAT, | ||
| &attachment_object->texture_internal_format_); | ||
| GLenum textarget = attachment_object->texture_target_; | ||
| glGetIntegerv(textarget, ¤t_texture_binding); |
There was a problem hiding this comment.
Incorrect use of glGetIntegerv with texture target. Should use the appropriate binding constant like GL_TEXTURE_BINDING_2D instead of the texture target enum directly.
Suggested change
| glGetIntegerv(textarget, ¤t_texture_binding); | |
| GLenum binding_constant = 0; | |
| if (textarget == GL_TEXTURE_2D) | |
| binding_constant = GL_TEXTURE_BINDING_2D; | |
| else if (textarget == GL_TEXTURE_2D_ARRAY) | |
| binding_constant = GL_TEXTURE_BINDING_2D_ARRAY; | |
| else if (textarget == GL_TEXTURE_2D_MULTISAMPLE) | |
| binding_constant = GL_TEXTURE_BINDING_2D_MULTISAMPLE; | |
| else | |
| assert(false && "Unsupported texture target."); | |
| glGetIntegerv(binding_constant, ¤t_texture_binding); |
| return *contentRenderer; | ||
| } | ||
|
|
||
| bool ContextGLApp::shouleExecuteDrawOnCurrent(GLsizei count) |
There was a problem hiding this comment.
Typo in method name: 'shouleExecuteDrawOnCurrent' should be 'shouldExecuteDrawOnCurrent'.
Suggested change
| bool ContextGLApp::shouleExecuteDrawOnCurrent(GLsizei count) | |
| bool ContextGLApp::shouldExecuteDrawOnCurrent(GLsizei count) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.