Skip to content

add a from_xml method#15

Merged
jsbroks merged 3 commits intojsbroks:masterfrom
EtienneDavid:xml_support
Oct 16, 2019
Merged

add a from_xml method#15
jsbroks merged 3 commits intojsbroks:masterfrom
EtienneDavid:xml_support

Conversation

@EtienneDavid
Copy link
Copy Markdown
Contributor

Hello,

I wrote some code to load a whole dataset made of XML. I think this method could help convert XML files to COCO JSON dataset, something missing in Github today. Your work on modelling Dataset, Image and Annotations made it very easy and this method could boost the popularity of this package.

An example on how it works is in example ("XML_format").

Copy link
Copy Markdown
Owner

@jsbroks jsbroks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also comment out the test case that is failing?

Comment thread imantics/image.py Outdated
Comment thread imantics/image.py Outdated
@EtienneDavid
Copy link
Copy Markdown
Contributor Author

The failed test was linked to the location of my own example images in example... I propose to leave an example_xml folder to solve the problem.

@EtienneDavid EtienneDavid requested a review from jsbroks October 14, 2019 17:19
Copy link
Copy Markdown
Owner

@jsbroks jsbroks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the example_xml contents into the data folder?

@EtienneDavid EtienneDavid requested a review from jsbroks October 15, 2019 07:06
@EtienneDavid
Copy link
Copy Markdown
Contributor Author

I've moved xml_example, create a coco_example and modify the tests

@jsbroks jsbroks merged commit a991932 into jsbroks:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants