Merged
Conversation
Owner
|
Hi, sorry I didn't get back to you about this earlier, as you know the last few months have been... interesting. This looks great, I'm going to merge it and use it myself for a little while. There are also a few other improvements I want to make (unrelated to this) but I'm aiming to do a new release in a week or so. Thanks again! PS can we close #1 now? |
Owner
|
This has been released in v0.8.0, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1
In regards to Yarn Plug'n'Play, I've selected to use
setup()function in.pnp.jsinstead ofyarn nodebecauselocate-dominating-fileis expensive intramp-mode. Howeversetup()has side effect of enabling to require module in zip archive (patch tofs), so I've changedprettier-processesthat will be able to keep node processes per project as much as possible.By the way, I tried prettier in
tramp-modefor the first time and gotError: ENOENT: no such file or directory, open '/tmp/prettier-emacs.71P4GP'. I think it maybe happens only in my environments so I replacedmake-temp-filewithmake-nearby-temp-fileand then it works fine.