Skip to content

Conversation

@jscottsmith
Copy link
Owner

Updates the controller scroll container in the ParallaxProvider when the element updates. See #56

@codecov-io
Copy link

codecov-io commented Apr 7, 2019

Codecov Report

Merging #57 into master will decrease coverage by 1.09%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #57     +/-   ##
=========================================
- Coverage   91.75%   90.65%   -1.1%     
=========================================
  Files          26       26             
  Lines         279      289     +10     
  Branches       46       47      +1     
=========================================
+ Hits          256      262      +6     
- Misses         18       23      +5     
+ Partials        5        4      -1
Impacted Files Coverage Δ
src/components/ParallaxProvider.js 100% <100%> (ø) ⬆️
src/classes/ParallaxController.js 74.02% <53.33%> (-7.14%) ⬇️
src/utils/validHTMLElement.js 87.5% <0%> (+37.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b73300...e5227f6. Read the comment docs.

@jscottsmith jscottsmith merged commit cb67ad7 into master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants